Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for csrfToken and project query #66

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

svennniiii
Copy link

@svennniiii svennniiii commented Mar 10, 2023

This fixes some bugs that prevent querying projects from overleaf (fixes #61). It is necessary due to design changes on the overleaf website. It updates the fix that was originally introduced by @itstorque.

@rayvburn
Copy link

I can only confirm that changes from this PR made it possible to query projects from the Overleaf again. Even this hack is not needed anymore. Thank your for your input!

@gfraysse
Copy link

Thank you, I can also confirm that this fixes the issue when login on the new Overleaf interface with CAPTCHA.
Minor issue I think: in my case, under Linux, the olbrowser waits until the compilation of the project is finished to end and resume the ols command. This was not the behavior before : the ols command resumed as soon as login was OK.

@rayvburn
Copy link

Did anybody have the issue with local -> remote sync not working? I've encountered that with both an older Overleaf project and a fresh one. Sync from remote to local works well.

I tried to debug that and added this:

print(f"upload file status code {r.status_code}")
print(f"upload file json        {json.loads(r.content)}")

at the end of the olclient's upload_file. The result is as follows:

upload file status code 422
upload file json        {'success': False, 'error': 'invalid_filename'}

Last time I've been using overleaf-sync with changes from this PR was 2 weeks ago and everything worked fine. I think that there were some API changes on the Overleaf side again. Could somebody confirm?

@YijunYuan
Copy link

The GCLB error happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Project details could not be queried.
5 participants