Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add moqui_http_log search/display to LogViewer screen #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jenshp
Copy link
Member

@jenshp jenshp commented Jan 26, 2021

Add a way to visualize and search the moqui_http_log index along the moqui_logs index.

Changed the text-line to specify the index to a drop-down, with both known indexes. Each index is rendered using a specific section as the fields are different.

@jonesde
Copy link
Member

jonesde commented Jan 26, 2021

A screen for viewing the http log would be great, but would be better as a separate screen instead of overloading the existing LogViewer screen. The general idea is that it is very different data being viewed, different columns and a chart with filtered data (by path, status, etc) would be really nice for http logs where it doesn't have so much value for system log messages. The index name should also stay editable as not all use the same index for logs, or may even have rotating indexes but supporting those would require something like the Kibana index names with wildcards.

@jenshp
Copy link
Member Author

jenshp commented Jan 27, 2021

Thanks for the feedback, I made a first version separating both index types into different screens, keeping the index name editable and considering the OOTB values as default names.

@acetousk
Copy link
Member

@jenshp Sorry it's taken so long to respond to this.

Do you mind updating your branch so I can try it out? It sounds like a good idea, and I think it's probably worth putting into Moqui

@jonesde
Copy link
Member

jonesde commented Jul 24, 2023

It looks like PR source has been updated for separate screens, but because the existing LogViewer screen was moved to a new location there are conflicts because the LogViewer.xml screen was updated to add page size.

One possible way to handle this would be to leave the LogViewer.xml screen where it is and as it is, and just add a separate HttpLog.xml screen next to it (ie no need to move the existing LogViewer.xml screen).

# Conflicts:
#	base-component/tools/screen/System/LogViewer.xml
@jenshp
Copy link
Member Author

jenshp commented Oct 18, 2023

Thanks for commenting on this, I just updated the PR to resolve the conflict, so you may try it out and see if you find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants