Add check-empty-type support to explicit load calls. #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "load" is requested from the moqui cli, then all given data load types are *always* run. However, if moqui is started normally, it has special support to load certain data items only the *first* time, when the database is empty(checked via looking for Enumeration records). This feature lets one specify check-empty-types, and load types. Then, always call "load" in the deployment process, and the first time through(empty database) it'll load seed,seed-initial, etc, and subsequent calls will just load seed.
|
I'm not sure what the objective or use case of this change is. Do you mind explaining that? It seems like you are adding another way to specify types of data to load conditionally if the database is not loaded (through an enumeration) unless they are specified in the load parameter (where they will always load) in a command line setting. |
|
There is a recently added feature to load data on start, separate from the empty db load, which sounds similar to what you describe. Here is the commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "load" is requested from the moqui cli, then all given data load types are always run. However, if moqui is started normally, it has special support to load certain data items only the first time, when the database is empty(checked via looking for Enumeration records).
This feature lets one specify check-empty-types, and load types. Then, always call "load" in the deployment process, and the first time through(empty database) it'll load seed,seed-initial, etc, and subsequent calls will just load seed.