Release v3.1.1

.github/ISSUE_TEMPLATE/bug_report.md → .github/ISSUE_TEMPLATE/bug.md

@@ -1,6 +1,6 @@
 ---
 name: Bug report
-about: Create a report to help us improve
+about: Create a bug report to help us improve.
 title: ''
 labels: ''
 assignees: ''
@@ -12,18 +12,19 @@ If you are not sure about anything below then please post on our [forum](https:/
 **Describe the bug**
 A clear and concise description of what the bug is. Is this specific to a particular Backend (e.g. Mopidy-Spotify), Frontend (e.g. Mopidy-MPD) or client?
 
-**To reproduce**
-Steps to reproduce the behaviour including any error messages that occur. 
+**How to reproduce**
+Steps to reproduce the behaviour including any error messages that occur.
 
 **Expected behaviour**
 A clear and concise description of what you expected to happen.
 
-**Environment (please complete the following information):**
+**Environment**
+Please complete the following information:
 - Operating system (e.g. Debian Buster, Ubuntu 20.04)
- - [Running Mopidy](https://docs.mopidy.com/en/latest/running/) as a service or in the terminal?
- - Your config (output of `sudo mopidyctl config`)
- - Software versions (output of `sudo mopidyctl deps`)
- - Any specific hardware (e.g. an exotic USB soundcard)
+- [Running Mopidy](https://docs.mopidy.com/en/latest/running/) as a service or in the terminal?
+- Your config (output of `sudo mopidyctl config`)
+- Software versions (output of `sudo mopidyctl deps`)
+- Any specific hardware (e.g. an exotic USB soundcard)
 
 **Additional context**
 Add any other context about the problem here. If appropriate, upload an [appropriately verbose](https://docs.mopidy.com/en/latest/troubleshooting/#debug-logging) log file showing the bug.

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: true
 contact_links:
- - name: Mopidy Discourse Forum
+ - name: Mopidy Discourse forum
  url: https://discourse.mopidy.com/
  about: Please ask and answer questions here.

.github/ISSUE_TEMPLATE/extension-request.md → .github/ISSUE_TEMPLATE/extension.md

@@ -1,6 +1,6 @@
 ---
-name: Extension Request
-about: Share your idea for a new Mopidy Extension.
+name: Extension request
+about: Share your idea for a new Mopidy extension.
 title: ''
 labels: C-extension-request
 assignees: ''

.github/ISSUE_TEMPLATE/feature_request.md → .github/ISSUE_TEMPLATE/feature.md

@@ -1,6 +1,6 @@
 ---
 name: Feature request
-about: Suggest an idea for this project
+about: Suggest an idea for this project.
 title: ''
 labels: ''
 assignees: ''

docs/changelog.rst

@@ -9,6 +9,13 @@ This changelog is used to track all major changes to Mopidy.
 For older releases, see :ref:`history`.
 
 
+v3.1.1 (2020-12-26)
+===================
+
+- Fix crash when extracting tags using gst-python >= 1.18. (PR:
+ :issue:`1948`)
+
+
 v3.1.0 (2020-12-16)
 ===================
 

docs/devenv.rst

@@ -284,7 +284,7 @@ processes in parallel, which usually cuts the test time in half or more::
 
  pytest -n 4
 
-Another useful feature from pytest-xdist, is the possiblity to stop on the
+Another useful feature from pytest-xdist, is the possibility to stop on the
 first test failure, watch the file system for changes, and then rerun the
 tests. This makes for a very quick code-test cycle::
 

docs/releasing.rst

@@ -42,7 +42,7 @@ stream-lined release procedure.
  "Create release" in the tag's dropdown menu.
 
 #. Copy the tag, e.g. ``v2.0.2`` into the "title" field. Write a changelog
- entry in the description field, and hit "Release".
+ entry in the description field, and hit "Publish release".
 
 #. GitHub Actions now builds the package and uploads it to PyPI.
 
@@ -133,7 +133,7 @@ Release
  "Create release" in the tag's dropdown menu.
 
 #. Copy the tag, e.g. ``v3.3.0`` into the "title" field. Write a changelog
- entry in the description field, and hit "Release".
+ entry in the description field, and hit "Publish release".
 
 #. GitHub Actions now builds the package and uploads it to PyPI.
 

mopidy/audio/tags.py

@@ -111,7 +111,14 @@ def _extract_buffer_data(buf):
  success, info = mem.map(Gst.MapFlags.READ)
  if not success:
  return None
- data = info.data
+ if isinstance(info.data, memoryview):
+ # We need to copy the data as the memoryview is released
+ # when we call mem.unmap()
+ data = bytes(info.data)
+ else:
+ # GStreamer Python bindings <= 1.16 return a copy of the
+ # data as bytes()
+ data = info.data
  mem.unmap(info)
  return data
 

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = Mopidy
-version = 3.1.0
+version = 3.1.1
 url = https://mopidy.com/
 project_urls =
  Documentation = https://docs.mopidy.com/
@@ -53,17 +53,13 @@ lint =
  flake8-isort
  isort[pyproject]
  pep8-naming
-release =
- build
- twine
 test =
  pytest
  pytest-cov
  responses
 dev =
  %(docs)s
  %(lint)s
- %(release)s
  %(test)s
  tox