Grouphandling #250
Open
Grouphandling #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 28, 2016 22:43
The grouplist gets read into memory and sorted by mk_user_get_groups, and they can then be looked for with a binary search in mk_group_in_grouplist. This will allow us later to check permissions if they correspond to secondary groups. Signed-off-by: Dominik Schmidt <[email protected]>
This shortcuts the O(log n) binary-search if the group is the EGID. Signed-off-by: Dominik Schmidt <[email protected]>
This fills the group-list with the effective secondary groups. Signed-off-by: Dominik Schmidt <[email protected]>
When we previously accessed a file, which belonged to an users secondary group, and we actually had permission to read it, monkey would deliver a 403. E.g. -rw-r--r-- 1 dominik httpd 218 18. Jun 2015 index.html would be reported unreadable, even if the user running monkey was part of the httpd-group. Signed-off-by: Dominik Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #244
I haven't done any benchmarking, but I'm guessing the performance impact to be marginal.