Reduced button sizes from Bootstrap's oversized defaults for improved aesthetics #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchabrowski
reviewed
Mar 12, 2024
| @@ -48,3 +48,12 @@ | |||
| border-radius: 4px; /* future proofing */ | |||
| -khtml-border-radius: 4px; /* for old Konqueror browsers */ | |||
| } | |||
|
|
|||
| .btn { | |||
There was a problem hiding this comment.
Overwriting all .btn styles with !important is not the best idea.
There was a problem hiding this comment.
agreed! It would be better create another class and not overwrite bootstrap's classes
There was a problem hiding this comment.
Please, make this, so I can merge it
There was a problem hiding this comment.
@jchabrowski Thank you for the suggestion. I Will make it . @shakaran
There was a problem hiding this comment.
@afridsyed326 You could try just reducing the number of columns that this buttons are using to one instead of two.
Closed
|
Does this still a issue or it will be updated or should I close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is