feat(ui): Migrating UI tests to use bun instead. #1716
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotcourant
commented
Mar 29, 2024
interface/src/pages/login.spec.tsx
Outdated
Comment on lines
11
to
24
| // const mockUseNavigate = mock((_url: string) => { }); | ||
| // // jest.mock('react-router-dom', () => ({ | ||
| // // __esModule: true, | ||
| // // ...jest.requireActual('react-router-dom'), | ||
| // // useNavigate: () => mockUseNavigate, | ||
| // // })); | ||
| // | ||
| // mock.module('react-router-dom', () => { | ||
| // return { | ||
| // // __esModule: true, | ||
| // // ...require('react-router-dom'), | ||
| // useNavigate: () => mockUseNavigate, | ||
| // }; | ||
| // }); |
There was a problem hiding this comment.
Still figuring out how to mock a hook from a module
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
==========================================
+ Coverage 50.46% 55.90% +5.43%
==========================================
Files 366 209 -157
Lines 20363 17871 -2492
Branches 500 0 -500
==========================================
- Hits 10276 9990 -286
+ Misses 9523 7308 -2215
- Partials 564 573 +9 ☔ View full report in Codecov by Sentry. |
elliotcourant
force-pushed
the
feature/bun-tests
branch
from
e2431a5
to
3be4e81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.