feat(api): Redo MFA to use scoped tokens. #1655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
- Coverage 52.59% 52.45% -0.14%
==========================================
Files 359 359
Lines 20378 20457 +79
Branches 482 482
==========================================
+ Hits 10717 10731 +14
- Misses 9041 9110 +69
+ Partials 620 616 -4 ☔ View full report in Codecov by Sentry. |
elliotcourant
force-pushed
the
feature/mfa-revision
branch
from
6d48c18
to
d12e78e
Compare
This is an effort to make MFA dependent on the audience of the token that was issued rather than a weird state where credentials must be resubmitted.
elliotcourant
force-pushed
the
feature/mfa-revision
branch
from
24901ad
to
88421b2
Compare
elliotcourant
commented
Feb 28, 2024
Comment on lines
+261
to
+263
| if err := me.Login.VerifyTOTP(request.TOTP, c.clock.Now()); err != nil { | ||
| return c.returnError(ctx, http.StatusUnauthorized, "invalid TOTP code") | ||
| } |
There was a problem hiding this comment.
Double check to see if this will remove the cookie, we need to keep that around. We dont want to remove it if they get it wrong, it should be good for a few minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to make MFA dependent on the audience of the token
that was issued rather than a weird state where credentials must be
resubmitted.