Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no such image #562

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: no such image #562

wants to merge 1 commit into from

Conversation

clemens-tolboom
Copy link
Collaborator

@clemens-tolboom clemens-tolboom commented Nov 29, 2023

DockerServiceTest.testGetProfileStatus

  • name is profileName
  • has unused imageID
  • Should use containerID instead of name
    • when(dockerClient.inspectContainerCmd(name).exec()).thenReturn(inspectContainerResponse);
  • Should use imageID instead of name
    • when(dockerClient.inspectImageCmd(name).exec().getRepoTags()).thenReturn(tags);

Trying to fix this makes tests fail.

How to test

  • run release-test.R and check the Insight log for "No such image"

2024-03-06 14:29:10.032 [http-nio-8080-exec-3|21ACB009] WARN o.m.armadillo.profile.DockerService - Couldn't inspect image
com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"No such image: xenon:latest"}

Docker

curl -s --unix-socket /var/run/docker.sock http:/v1.24/images/xenon/json 
# {"message":"No such image: xenon:latest"}

while following gives a expected answer

curl -s --unix-socket /var/run/docker.sock "http:/v1.24/images/datashield/rock-dolomite-xenon:latest/json"
# {"Id":"sha256:87038582f0 ....

@clemens-tolboom clemens-tolboom changed the title Fixes #528 No such image Nov 29, 2023
@clemens-tolboom clemens-tolboom self-assigned this Nov 29, 2023
@clemens-tolboom clemens-tolboom removed the request for review from marikaris November 29, 2023 16:34
@clemens-tolboom
Copy link
Collaborator Author

I missed running tests DockerServiceTest.testGetProfileStatus

@clemens-tolboom clemens-tolboom marked this pull request as draft December 6, 2023 11:12
@mswertz mswertz changed the title No such image fix: no such image Feb 22, 2024
@clemens-tolboom clemens-tolboom linked an issue Feb 27, 2024 that may be closed by this pull request
@clemens-tolboom clemens-tolboom added this to the Sprint 218 milestone Feb 29, 2024
@marikaris marikaris modified the milestones: Sprint 219, Backlog May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such image: default:latest
2 participants