Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call POSIX::setsid() as a function #2053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atoomic
Copy link

@atoomic atoomic commented Mar 20, 2023

This is avoiding a warning when load with strict sub enabled:

Bareword "POSIX::setsid" not allowed while "strict subs" in use

This is avoiding a warning when load with strict sub
enabled:

    Bareword "POSIX::setsid" not allowed while "strict subs" in use
@Grinnz
Copy link
Contributor

Grinnz commented Mar 20, 2023

If you are encountering this error, then the function will not work. What system does not have POSIX::setsid defined?

@atoomic
Copy link
Author

atoomic commented Mar 20, 2023

The problem is not POSIX::setid being defined or not. This is a warning when load with strict subs that I can fix on my side when applying this patch. This probably indicates another issue but was considering using parens to call the function a good thing.
If you disagree let's close this PR.

@Grinnz
Copy link
Contributor

Grinnz commented Mar 20, 2023

This is certainly an indication of another issue. There should be no case in which the POSIX::setsid symbol is undefined in the parser.

@toddr
Copy link

toddr commented Mar 22, 2023

This is certainly an indication of another issue. There should be no case in which the POSIX::setsid symbol is undefined in the parser.

Can't we just merge it as "more legible code?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants