fix(quasar-cli-vue3): fixed prod builds #3208

lexasq · 2023-10-24T07:21:34Z

Fix for #3173

vercel · 2023-10-24T07:21:40Z

@lexasq is attempting to deploy a commit to the Module Federation Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2023-10-24T07:38:54Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

github-actions · 2023-10-24T08:03:12Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

brunos3d · 2023-10-24T12:42:50Z

quasar-cli-vue3-webpack-javascript/app-exposes/.quasar/client-entry.js

+const publicPath = `http://localhost:3001/`
+
+const doubleSlashRE = /\/\//
+const addPublicPath = url => (publicPath + url).replace(doubleSlashRE, '/')


Just asking shall we use global replace/replace all occurrences here?

I believe it's autogenerated folder

github-actions · 2023-10-24T12:58:59Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

goldyfruit · 2023-10-24T22:34:15Z

Just tried the PR, when trying to quasar dev on app-general I got this:

viktoriialurie · 2023-10-25T08:48:41Z

@goldyfruit the readme has been changed, could you please try to check with the updated instructions?

goldyfruit · 2023-10-25T11:36:02Z

@goldyfruit the readme has been changed, could you please try to check with the updated instructions?

This is the error I got with the new README

lexasq · 2023-10-25T11:40:31Z

@goldyfruit the readme has been changed, could you please try to check with the updated instructions?

This is the error I got with the new README

Hi, could you please share content of your env file?

github-actions · 2023-10-25T11:51:08Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

…module-federation-examples into alex-quasar-cli-vue3-fix

github-actions · 2023-10-25T11:54:35Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

lexasq · 2023-10-25T11:54:58Z

@goldyfruit I think I understood your struggle, the updates were made per app READMEs, duplicated those changes to common file as well, hopefully that'll help.

goldyfruit · 2023-10-25T13:00:54Z

@goldyfruit I think I understood your struggle, the updates were made per app READMEs, duplicated those changes to common file as well, hopefully that'll help.

Indeed, following the new README allows me to run quasar dev.

The build instructions failed on app-general, complaining about Loading failed for the <script> with source “http://localhost:4000/js/main.29127d47.js”.

Thanks for your help @lexasq

goldyfruit · 2023-10-25T13:06:15Z

Issues seems related to some files with port 4000 referenced in app-general.

.quasar/client-entry.js
envs/env.prod.json
envs/env.json

lexasq · 2023-10-25T13:08:20Z

@goldyfruit looks weird, just retested that and its fine. As for the build you got to check the respective instruction in the apps.

goldyfruit · 2023-10-25T13:10:51Z

Issues seems related to some files with port 4000 referenced in app-general.

.quasar/client-entry.js

envs/env.prod.json

envs/env.json

@lexasq After changing port 4000 to 3000 in the files listed above and re-run quasar build its working.

lexasq · 2023-10-25T13:25:18Z

Issues seems related to some files with port 4000 referenced in app-general.

.quasar/client-entry.js

envs/env.prod.json

envs/env.json

@lexasq After changing port 4000 to 3000 in the files listed above and re-run quasar build its working.

Don't change anything manually, follw the READMEs

goldyfruit · 2023-10-25T13:35:45Z

Don't change anything manually, follw the READMEs

Did it again to make sure (with a fresh clone from your branch), I followed the instructions from the README for both app-expose and app-general:

yarn
yarn lint
yarn format
yarn setup-env:prod
quasar build

Same result:

lexasq · 2023-10-25T13:37:32Z

Don't change anything manually, follw the READMEs

Did it again to make sure (with a fresh clone from your branch), I followed the instructions from the README for both app-expose and app-general:
yarn
yarn lint
yarn format
yarn setup-env:prod
quasar build
Same result:

You most definitely didin't, app-general is set to be hosted on port 4000.

goldyfruit · 2023-10-25T13:41:30Z

@goldyfruit looks weird, just retested that and its fine. As for the build you got to check the respective instruction in the apps.

But in this screenshot you are running on port 3000, I'm confused.

goldyfruit · 2023-10-25T13:42:50Z

@goldyfruit looks weird, just retested that and its fine. As for the build you got to check the respective instruction in the apps.

But in this screenshot you are running on port 3000, I'm confused.

When running quasar serve on port 4000 its working. 👍

goldyfruit · 2023-10-25T13:47:47Z

One side note, maybe the main README should be updated with the correct ports as well:

Thanks again for your help (and patience) @lexasq

lexasq · 2023-10-25T13:49:44Z

Uploading quasar.webm…
@goldyfruit

lexasq · 2023-10-25T13:51:31Z

One side note, maybe the main README should be updated with the correct ports as well:

Thanks again for your help (and patience) @lexasq

You can change port in the env file for prod, just don't forget to use the correct command for quasar, as for the dev you change port in the config file.

goldyfruit · 2023-10-25T13:52:55Z

One side note, maybe the main README should be updated with the correct ports as well:

Thanks again for your help (and patience) @lexasq

You can change port in the env file for prod, just don't forget to use the correct command for quasar, as for the dev you change port in the config file.

Thanks!

github-actions · 2023-10-25T14:13:09Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

goldyfruit · 2023-10-25T14:19:04Z

quasar-cli-vue3-webpack-javascript/app-exposes/README.md

@@ -37,6 +37,8 @@ npm run format
 ```bash
 yarn setup-env:prod
 quasar build
+cd dist spa


Should be dist/spa.

goldyfruit · 2023-10-25T14:19:18Z

quasar-cli-vue3-webpack-javascript/app-general/README.md

@@ -37,6 +37,8 @@ npm run format
 ```bash
 yarn setup-env:prod
 quasar build
+cd dist spa


Should be dist/spa as well.

Thanks, overlooked that!

github-actions · 2023-10-25T14:24:25Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

github-actions · 2023-11-01T09:40:53Z

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

fix(quasar-cli-vue3): fixed prod builds

eec9ee2

fix(quasar-cli-vue3): fixed prod builds

fd83439

github-actions bot added the workflow-failure Workflow is failed label Oct 24, 2023

fix(quasar-cli-vue3): fixed prod builds

3fb3dde

CaioRolla approved these changes Oct 24, 2023

View reviewed changes

brunos3d reviewed Oct 24, 2023

View reviewed changes

Merge branch 'master' into alex-quasar-cli-vue3-fix

70a69ae

Merge branch 'master' into alex-quasar-cli-vue3-fix

3705570

lexasq added 2 commits October 25, 2023 14:51

fix(quasar-cli-vue3-webpack-javascript): updated general README

1c64f24

Merge branch 'alex-quasar-cli-vue3-fix' of https://github.com/lexasq/…

f2e9c29

…module-federation-examples into alex-quasar-cli-vue3-fix

fix(quasar-cli-vue3-webpack-javascript): updated READMEs

72cd39d

goldyfruit reviewed Oct 25, 2023

View reviewed changes

fix(quasar-cli-vue3-webpack-javascript): updated READMEs

c90ff23

goldyfruit approved these changes Oct 25, 2023

View reviewed changes

fix(branch): merged master

74ffa75

lexasq merged commit 067477a into module-federation:master Nov 1, 2023
9 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(quasar-cli-vue3): fixed prod builds #3208

fix(quasar-cli-vue3): fixed prod builds #3208

lexasq commented Oct 24, 2023 •

edited

vercel bot commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

brunos3d Oct 24, 2023

lexasq Oct 24, 2023

github-actions bot commented Oct 24, 2023

goldyfruit commented Oct 24, 2023 •

edited

viktoriialurie commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 •

edited

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 •

edited by lexasq

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 •

edited

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

goldyfruit Oct 25, 2023

goldyfruit Oct 25, 2023

lexasq Oct 25, 2023

github-actions bot commented Oct 25, 2023

github-actions bot commented Nov 1, 2023

fix(quasar-cli-vue3): fixed prod builds #3208

fix(quasar-cli-vue3): fixed prod builds #3208

Conversation

lexasq commented Oct 24, 2023 • edited

vercel bot commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

brunos3d Oct 24, 2023

Choose a reason for hiding this comment

lexasq Oct 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2023

goldyfruit commented Oct 24, 2023 • edited

viktoriialurie commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 • edited

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 • edited by lexasq

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023 • edited

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

lexasq commented Oct 25, 2023

lexasq commented Oct 25, 2023

goldyfruit commented Oct 25, 2023

github-actions bot commented Oct 25, 2023

goldyfruit Oct 25, 2023

Choose a reason for hiding this comment

goldyfruit Oct 25, 2023

Choose a reason for hiding this comment

lexasq Oct 25, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 25, 2023

github-actions bot commented Nov 1, 2023

lexasq commented Oct 24, 2023 •

edited

goldyfruit commented Oct 24, 2023 •

edited

goldyfruit commented Oct 25, 2023 •

edited

goldyfruit commented Oct 25, 2023 •

edited by lexasq

goldyfruit commented Oct 25, 2023 •

edited