Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] implement os.path.getsize #2626

Closed
wants to merge 1 commit into from

Conversation

artemiogr97
Copy link
Contributor

Implementation for #1130

@artemiogr97 artemiogr97 requested a review from a team as a code owner May 11, 2024 19:35
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.

@artemiogr97
Copy link
Contributor Author

@JoeLoser I just modified the changelog

Signed-off-by: Artemio Garza Reyna <[email protected]>
@JoeLoser
Copy link
Collaborator

!sync

@JoeLoser JoeLoser added the imported-internally Signals that a given pull request has been imported internally. label May 20, 2024
@modularbot modularbot added the merged-externally Merged externally in public mojo repo label May 21, 2024
@modularbot
Copy link
Collaborator

Landed in e0f68ac! Thank you for your contribution 🎉

modularbot added a commit that referenced this pull request May 21, 2024
[External] [stdlib] Implement `os.path.getsize`

Add `getsize` method for getting the size (in bytes)
of a path.

Fixes #1130

ORIGINAL_AUTHOR=artemiogr97
<[email protected]>
PUBLIC_PR_LINK=#2626

Co-authored-by: artemiogr97 <[email protected]>
Closes #2626
MODULAR_ORIG_COMMIT_REV_ID: 443260f3be31a694c9e93fc11b64d0317646c4e0
@modularbot modularbot closed this May 21, 2024
martinvuyk pushed a commit to martinvuyk/mojo that referenced this pull request May 24, 2024
[External] [stdlib] Implement `os.path.getsize`

Add `getsize` method for getting the size (in bytes)
of a path.

Fixes modularml#1130

ORIGINAL_AUTHOR=artemiogr97
<[email protected]>
PUBLIC_PR_LINK=modularml#2626

Co-authored-by: artemiogr97 <[email protected]>
Closes modularml#2626
MODULAR_ORIG_COMMIT_REV_ID: 443260f3be31a694c9e93fc11b64d0317646c4e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants