[stdlib] Use UInt8 to store characters in String
#2612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that there are so many changes to do means that many functions access
String
's internal buffer without going through the method provided (for exampleunsafe_ptr()
). It might be worth it to rework a bit the API so that when we change theString
's internals later on, we don't have to touch too many things. I'm notably thinking here about SSO and Unicode.This PR is part of #2317
Thanks god ASCII chars are between 0 and 127...