Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mojo-stdlib] Add b16encode and b16decode to base64 module #2584

Closed
wants to merge 6 commits into from

Conversation

kernhanda
Copy link

This change adds b16encode and b16decode to the base64 module, as well as relevant tests.

The initial implementation is simple and can be optimized in future iterations (if needed).

#474

@kernhanda kernhanda requested a review from a team as a code owner May 8, 2024 07:39
@JoeLoser JoeLoser added the imported-internally Signals that a given pull request has been imported internally. label May 8, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels May 16, 2024
@modularbot
Copy link
Collaborator

Landed in 9aff94f! Thank you for your contribution 🎉

modularbot pushed a commit that referenced this pull request May 17, 2024
… (#39561)

[External] [mojo-stdlib] Add b16encode and b16decode to base64 module

This change adds `b16encode` and `b16decode` to the `base64` module, as
well as relevant tests.

The initial implementation is simple and can be optimized in future
iterations (if needed).

#474

Co-authored-by: Kern Handa <[email protected]>
Closes #2584
MODULAR_ORIG_COMMIT_REV_ID: 341c7f3656c041f37d76e6c8b382b92c8762f74e
@modularbot modularbot closed this May 17, 2024
msaelices pushed a commit to msaelices/mojo that referenced this pull request May 18, 2024
… (#39561)

[External] [mojo-stdlib] Add b16encode and b16decode to base64 module

This change adds `b16encode` and `b16decode` to the `base64` module, as
well as relevant tests.

The initial implementation is simple and can be optimized in future
iterations (if needed).

modularml#474

Co-authored-by: Kern Handa <[email protected]>
Closes modularml#2584
MODULAR_ORIG_COMMIT_REV_ID: 341c7f3656c041f37d76e6c8b382b92c8762f74e
martinvuyk pushed a commit to martinvuyk/mojo that referenced this pull request May 24, 2024
… (#39561)

[External] [mojo-stdlib] Add b16encode and b16decode to base64 module

This change adds `b16encode` and `b16decode` to the `base64` module, as
well as relevant tests.

The initial implementation is simple and can be optimized in future
iterations (if needed).

modularml#474

Co-authored-by: Kern Handa <[email protected]>
Closes modularml#2584
MODULAR_ORIG_COMMIT_REV_ID: 341c7f3656c041f37d76e6c8b382b92c8762f74e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants