[stdlib] add Defaultable trait
#2526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhan211
reviewed
May 5, 2024
| ``` | ||
| """ | ||
|
|
||
| fn __init__(inout self): |
There was a problem hiding this comment.
Can we have the name default
JoeLoser
approved these changes
May 10, 2024
JoeLoser
added
the
imported-internally
Signed-off-by: Max Brylski <[email protected]>
helehex
force-pushed
the
feature/defaultable
branch
from
0771a45
to
64e8a1c
Compare
|
i simplified the docstring |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
May 14, 2024
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <[email protected]> Closes #2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425
|
Landed in 60f5b04! Thank you for your contribution 🎉 |
rd4com
pushed a commit
to rd4com/mojo_branch
that referenced
this pull request
May 15, 2024
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <[email protected]> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425 Signed-off-by: rd4com <[email protected]>
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <[email protected]> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425 Signed-off-by: Lukas Hermann <[email protected]>
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <[email protected]> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
Defaultabletrait for describing a type which has a constructor with no arguments