Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.ipynb , fixed typo #2516

Closed
wants to merge 2 commits into from
Closed

Update types.ipynb , fixed typo #2516

wants to merge 2 commits into from

Conversation

mcroni
Copy link

@mcroni mcroni commented May 5, 2024

No description provided.

@ematejska ematejska added the mojo-repo Tag all issues with this label label May 6, 2024
@JoeLoser JoeLoser requested a review from a team May 10, 2024 03:24
@JoeLoser
Copy link
Collaborator

Thanks for the fix. Do you mind targeting the nightly branch instead as the docs say? Otherwise, we won't be able to import this PR and merge it.

@mcroni mcroni closed this May 15, 2024
@mcroni mcroni reopened this May 15, 2024
@mcroni
Copy link
Author

mcroni commented May 15, 2024

can't seem to push to nightly

@JoeLoser
Copy link
Collaborator

can't seem to push to nightly

Did you follow along at https://github.com/modularml/mojo/blob/nightly/CONTRIBUTING.md#branching-off-nightly? You want to push to a local branch on your remote/fork - you can call that branch whatever you want as long as it's based off of the nightly branch from modularml/mojo repo.

@Brian-M-J
Copy link

can't seem to push to nightly

Can you elaborate on what exactly is preventing you from doing so? See this comment for some suggestions on what to do.

@Brian-M-J
Copy link

Actually, it seems this has already been fixed in the nightly branch (by me 😅). See commit 565586f

@JoeLoser
Copy link
Collaborator

Actually, it seems this has already been fixed in the nightly branch (by me 😅). See commit 565586f

Thanks - closing as such.

@JoeLoser JoeLoser closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mojo-repo Tag all issues with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants