WIP: Webautn support #3238
Open
WIP: Webautn support #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: modify the middleware to certify the user has successfully used it...
tonioo
requested changes
May 29, 2024
| get_creds_from_user(request.user.pk), | ||
| user_verification=UserVerificationRequirement.DISCOURAGED | ||
| ) | ||
| request.session['fido2_state'] = state |
There was a problem hiding this comment.
Are you sure you want to use a session?
There was a problem hiding this comment.
Why not ? I need to store this while the client respond with the payload to *_end. Is there something to know ?
There was a problem hiding this comment.
Because sessions won't work with the API...
| @@ -27,7 +27,7 @@ def delete_cache_key(class_target, throttles, request): | |||
| """Attempt to delete cache key from throttling on login/password reset success.""" | |||
|
|
|||
| for throttle in throttles: | |||
| if type(throttle) == class_target: | |||
| if type(throttle) is class_target: | |||
There was a problem hiding this comment.
isinstance might be a better choice here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2331