REFACTOR-#7242: Add type hints for modin/core/dataframe/algebra/
#7243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
issue7242
branch
2 times, most recently
from
91543e8
to
130f489
Compare
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
May 8, 2024
| groupby_kwargs: dict, | ||
| agg_args: list, | ||
| agg_kwargs: dict, | ||
| other: Optional[pandas.DataFrame] = None, | ||
| by=None, |
There was a problem hiding this comment.
Some arguments are very complex in terms of the types they accept. I leave them untouched, because for now I am trying to improve code navigation with the least effort, so as not to spend a lot of time on it and be able to do it as I work on another task (but in the same place in the code).
| @@ -50,6 +52,10 @@ | |||
|
|
|||
| from . import doc_utils | |||
|
|
|||
| if TYPE_CHECKING: | |||
| # TODO: should be ModinDataframe | |||
There was a problem hiding this comment.
When is this going to be fixed?
…/algebra/' Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
|
@YarShev ready for review |
YarShev
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -smodin/core/dataframe/algebra/#7242docs/development/architecture.rstis up-to-date