Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#7151: Remove usage of pandas._testing private module #6988

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

TEST-#7151: Remove usage of pandas._testing private module #6988

wants to merge 3 commits into from

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Mar 1, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove usage of pandas._testing private module #7151
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title TEST-#0000: don't use pandas._testing.ensure_clean TEST-#7151: Remove usage of pandas._testing private module Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aregm aregm Awaiting requested review from aregm aregm will be requested when the pull request is marked ready for review aregm is a code owner

@gshimansky gshimansky Awaiting requested review from gshimansky gshimansky will be requested when the pull request is marked ready for review gshimansky is a code owner

@ienkovich ienkovich Awaiting requested review from ienkovich ienkovich will be requested when the pull request is marked ready for review ienkovich is a code owner

@Garra1980 Garra1980 Awaiting requested review from Garra1980 Garra1980 will be requested when the pull request is marked ready for review Garra1980 is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev will be requested when the pull request is marked ready for review YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov will be requested when the pull request is marked ready for review vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev will be requested when the pull request is marked ready for review dchigarev is a code owner

@AndreyPavlenko AndreyPavlenko Awaiting requested review from AndreyPavlenko AndreyPavlenko will be requested when the pull request is marked ready for review AndreyPavlenko is a code owner

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn will be requested when the pull request is marked ready for review devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha will be requested when the pull request is marked ready for review mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD will be requested when the pull request is marked ready for review RehanSD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of pandas._testing private module
1 participant
@anmyachev