-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow env values in setLocation command #1769
base: main
Are you sure you want to change the base?
Conversation
@prasanta-biswas thank you! I was about to open a PR solving this exact same issue |
@@ -33,7 +33,7 @@ internal class MaestroCommandTest { | |||
@Test | |||
fun `description (with a label)`() { | |||
// given | |||
val maestroCommand = MaestroCommand(SetLocationCommand(12.5266, 78.2150, "Set Location to Test Laboratory")) | |||
val maestroCommand = MaestroCommand(SetLocationCommand("12.5266", "78.2150", "Set Location to Test Laboratory")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a test using negative coordinates ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alaksion done. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Hello @prasanta-biswas
|
Hi @lucaswiechmann Here is the build log
|
@lucaswiechmann possible to merge this? |
Proposed Changes
Fixes an issue where setLocation command fails if latitude and longitude values are passed from environment variables.
Testing
./gradlew :maestro-test:test
, all tests passed.env
keyword. It worked for both inline-defined latitude and longitude and passed from env.Issues Fixed
#1765