Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to turn off https repo url to private recipes #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add option to turn off https repo url to private recipes #14

wants to merge 1 commit into from

Conversation

lainosantos
Copy link
Contributor

This PR is because sometimes privates git server has ssh url enabled, but not have https url enabled. Example: i'm using a private gitlab server with ssh enabled, but i not use https on this server.

Currentily, if a private recipes repo has a git ssh url, the recipes url is always https.

@lainosantos
Copy link
Contributor Author

This PR contains the changes fixs of #11 because the compiled js.

@lainosantos
Copy link
Contributor Author

Rebased after after #11 has been merged.

@moay
Copy link
Owner

moay commented Jul 13, 2018

Thanks for the cleanup. I thought on this issue and I think we should rethink the solution. It does not feel right to inject the information on https or not into the status report config only to have the variable available in the ui. A better solution would be to integrate this information into the git repo class and have it available there. The repo should have it's own propery baseHttpUrl or similar which should then contain the preparsed http(s) url (from the ssh url if needed).

What do you think on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants