Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple links #164

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Support multiple links #164

merged 7 commits into from
Apr 19, 2021

Conversation

makew0rld
Copy link
Contributor

@makew0rld makew0rld commented Nov 23, 2020

This adds a Links var to Feed and Items. This was mainly created to allow the usage of Atom feeds with multiple links for each item, but the variable captures RSS feeds that have multiple links for a feed as well. It's not really useful for JSON, but it still captures the single link as one would expect.

@coveralls
Copy link

coveralls commented Nov 23, 2020

Coverage Status

Coverage increased (+0.4%) to 74.568% when pulling d407d33 on makeworld-the-better-one:master into 68eef24 on mmcdole:master.

@makew0rld
Copy link
Contributor Author

@mmcdole All tests now pass, and all merge conflicts have been resolved. Can this be merged? Thanks!

@ecliptik
Copy link

@mmcdole ping if this could get reviewed and merged as it would help with some Debian packaging too. Thank you.

@nileshpatra
Copy link

nileshpatra commented Apr 19, 2021

@mmcdole ping again. This is really important for us. I'd really appreciate if you could merge this and if possible tag a patch/minor release.
This would help unblock a bunch of packaging work

@mmcdole
Copy link
Owner

mmcdole commented Apr 19, 2021

@nileshpatra @ecliptik would #153 also solve this for you?

@makew0rld
Copy link
Contributor Author

@mmcdole Thanks for responding. I don't think so? It doesn't look like that supports multiple Atom links.

@nileshpatra
Copy link

nileshpatra commented Apr 19, 2021

@mmcdole @drakenot I agree with makeworld there, it likely won't

@Necoro
Copy link
Contributor

Necoro commented Apr 19, 2021

Chiming in here too: No, the two PRs are orthogonal.

@mmcdole mmcdole merged commit 41f47c9 into mmcdole:master Apr 19, 2021
@mmcdole
Copy link
Owner

mmcdole commented Apr 19, 2021

Thanks everyone. I see now that this was adding it to Atom as well.

I knew that @Necoro's PR allowed the parsing of Atom elements in the RSS feed. I didn't want a one-off Atom element in RSS if there was a way to parse any atom element within an RSS feed.

@makew0rld
Copy link
Contributor Author

Thank you for merging!

To others: Amfora has updated in makew0rld/amfora@6fa3600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants