Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom user agent support on rss.Parser #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added custom user agent support on rss.Parser #108

wants to merge 1 commit into from

Conversation

GaruGaru
Copy link

Related to #74
Some feed such as reddit's rss feed provide a very low request rate for bots, it would be nice to have an easy to use way to set a user defined user agent for the parser

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6 on GaruGaru:master into eb870fd on mmcdole:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6 on GaruGaru:master into eb870fd on mmcdole:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6 on GaruGaru:master into eb870fd on mmcdole:master.

@bogatuadrian
Copy link

@mmcdole Will this be merged? Is it because coverage cc @GaruGaru?

@OrKoN
Copy link
Contributor

OrKoN commented Apr 11, 2019

I think it does not add much value: one can always use http to fetch and parse with fp.Parse. It's even a good idea to implement your own download function to handle network errors/retries/headers/etc better

@lmas
Copy link

lmas commented May 14, 2019

Would still love to have this option for when making quick prototypes and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants