Fix RSS enclosure parsing (#218)

* fix(rss): fix enclosure parsing, ignoring every child nodes, not only text

* feat: add unit test for issue #217

rss/parser.go

@@ -505,14 +505,16 @@ func (rp *Parser) parseEnclosure(p *xpp.XMLPullParser) (enclosure *Enclosure, er
  enclosure.Length = p.Attribute("length")
  enclosure.Type = p.Attribute("type")
 
- // Ignore any enclosure text
- _, err = p.NextText()
- if err != nil {
- return enclosure, err
- }
+ // Ignore any enclosure tag
+ for {
+ _, err := p.Next()
+ if err != nil {
+ return enclosure, err
+ }
 
- if err = p.Expect(xpp.EndTag, "enclosure"); err != nil {
- return nil, err
+ if p.Event == xpp.EndTag && p.Name == "enclosure" {
+ break
+ }
  }
 
  return enclosure, nil

testdata/parser/rss/issue_217_enclosure_children.json

@@ -0,0 +1,17 @@
+{
+ "items": [
+ {
+ "enclosure": {
+ "url": "http://example.org/enclosure.jpg",
+ "type": "image/jpeg"
+ },
+ "enclosures": [
+ {
+ "url": "http://example.org/enclosure.jpg",
+ "type": "image/jpeg"
+ }
+ ]
+ }
+ ],
+ "version": "2.0"
+}

testdata/parser/rss/issue_217_enclosure_children.xml

@@ -0,0 +1,23 @@
+
+<!--
+Description: issue #217 
+-->
+<rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/">
+ <channel>
+ <item>
+
+ <enclosure url="http://example.org/enclosure.jpg" type="image/jpeg">
+ <media:title>
+ <![CDATA[ <p>Enclosure test title</p> ]]>
+ </media:title>
+ <media:copyright>
+ <![CDATA[ Enclosure copyright ]]>
+ </media:copyright>
+ <media:credits>
+ <![CDATA[ Enclosure credits ]]>
+ </media:credits>
+ </enclosure>
+
+ </item>
+ </channel>
+</rss>