Updating repo to newest version of Phoenix #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know your work on couchdb is on maintenance mode and you might not care as much about this PR, but I found your blog post helpful and figured I would take a crack at upgrading the dependencies to something more modern. Both
mix phx.serverandmix testwork as expected. Most changes are either renaming to the new convention asBirdWatchWebor updating to mix format. Putting in a PR in case you find this helpful. I'd be interested in taking a crack at couchdb_connector too since it is throwing a lot of warnings now, but it seems to be pretty much the couchdb library these days.I also wouldn't care if this got closed too, it at least gives a paper trail from other people having issues running it on the newer version of Elixir/Phoenix.