Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when using event-emitter interface #217

Open
Page- opened this issue Jul 11, 2022 · 3 comments
Open

Memory leak when using event-emitter interface #217

Page- opened this issue Jul 11, 2022 · 3 comments
Labels

Comments

@Page-
Copy link

Page- commented Jul 11, 2022

With the introduction of ce2bb8e by @kshetline it means that all data is stored in the pendingData property and is only removed when you use the nextData() interface which means that if you instead use the event-emitter interface, eg .on('data', ...) then pendingData will grow indefinitely

Page- added a commit to balena-io/open-balena-vpn that referenced this issue Jul 11, 2022
@mkozjak
Copy link
Owner

mkozjak commented Jul 11, 2022

Nice find! Able to fix this asap so Balena doesn't need to be downgraded?

@mkozjak mkozjak added the bug label Jul 11, 2022
Page- added a commit to balena-io/open-balena-vpn that referenced this issue Jul 11, 2022
Page- added a commit to balena-io/open-balena-vpn that referenced this issue Jul 11, 2022
Page- added a commit to balena-io/open-balena-vpn that referenced this issue Jul 11, 2022
@Page-
Copy link
Author

Page- commented Jul 11, 2022

I do plan to look into a fix but first I need to resolve the issue for balena

@mkozjak
Copy link
Owner

mkozjak commented Jul 11, 2022

Thanks so much, @Page- !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants