Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to telnet-client 1.x to avoid memory leak #277

Merged
1 commit merged into from
Jul 11, 2022
Merged

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Jul 11, 2022

See: mkozjak/node-telnet-client#217

Change-type: patch

Change-type: major|minor|patch
Connects-to: #
See:
Depends-on:


Contributor checklist
  • Build output has been rebuilt and tested
  • Introduces security considerations
  • Tests are included
  • Documentation is added or changed
  • Affects the development, build or deployment processes of the component
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@Page- Page- marked this pull request as ready for review July 11, 2022 11:07
@Page-
Copy link
Contributor Author

Page- commented Jul 11, 2022

@balena-ci I self-certify!

@ghost ghost merged commit 1d5ab9f into master Jul 11, 2022
@ghost ghost deleted the telnet-client-1 branch July 11, 2022 13:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant