Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #68
@tomquirk
Some concerns:
I couldn't emulate giphy functionality completely. The giphy API provides an embed url, which I can pass as a url paramter in the message and it embeds correctly in messenger most of the time, but you have to press play and it's not at all like the real gify. The API also provides a URL for the looping gif, but when I send it as an url element, it doesn't display. I tried looking at the documentation for the facebook chat API, but I don't think the library you're using supports all of it. It would be great if you could give me a hint about how I should pass the looping url so it displays correctly.
I left my API key as a default option. I don't think it's too much hassle and giphy actually encourages registering apps. We should encourage users to configure it with their own API key and not commit to support ourselves, but it's nice to have a default.
Tests for gifs are a bit slow, because you're embedding stuff and I'm wondering if they should be removed entirely.
Should I update the doc, or will you update it after you merge V1?