Support for nested <ul>/<ol> tags without <li> (not technically valid) #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix invalid markdown when <ul> is nested inside an empty <li> - add support for nested <ul>/<ol> outside of <li> (a common and widely supported usage, though not technically valid)
- empty li is allowed in html and markdown (who does this on purpose?) - fixed edge case of numbering when <ol>s are nested without <li>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this pull request for your re-consideration of issue #232. My reasoning is this:
Please see my comment on #232.
Note that this PR differs slightly from the code that I pasted there; I think it's unnecessary to "fix" the case with an empty
<li>element (<li><ul>...</ul></li>) because the meaning is preserved in the resulting markdown.