Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden Rules #874

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Hidden Rules #874

wants to merge 7 commits into from

Conversation

gordon-matt
Copy link

This relates to issue #825 . My colleague has left the organization, so I forked his work and am submitting it here.

@mistic100
Copy link
Owner

  1. please do not modify the README, add things that should be in the doc, add new dependencies or modify the existing example
  2. I don't want to integrate that in the core, it has to be a plugin

It's clearly a WIP for your need and cannot be integrated as it.

@gordon-matt
Copy link
Author

Yeah, like I tried to say: I didn't modify anything.. it was my colleague and he is gone now.. so I thought I'd just submit this Pull Request so we don't lose the code changes he did.

If you don't like the way he implemented it, sure.. no worries. Just leave it here to look at when you have the time to do your own implementation and then close it when you're done.

@mistic100
Copy link
Owner

Ok.
BTW openning a pull request won't prevent to lose the code. Your repository is the only owner of this code.

@gordon-matt
Copy link
Author

Yes, but this way you can more easily see what has been changed, which may (or may not) give you inspiration for your own implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants