feat: ミュートされたユーザーのリアクションをレスポンスに含めないようにする(#13456) #13827
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
note.reactionAndUserPairCache
に含まれるユーザーのみを対象とするWhy
#13456
Additional info (optional)
note.reactionAndUserPairCache
に含まれるユーザーのみを対象とするため、現状では最初から数えてPER_NOTE_REACTION_USER_PAIR_CACHE_MAX(=16)
のユーザーのみが処理されるMkReactionsViewer.details.vue
等)に表示されないようミュートするmisskeyApiGet('notes/reactions', {...})
をmisskeyApi('notes/reactions', {...})
に置き換えているnotes/reactions
の内部においてミュートの情報を参照するためにユーザー情報が必要であり、このためPOSTリクエストでCredentialsを含める必要があるからである(が、PR作成者はAPI呼び出しの仕様を詳しく把握できなかったので、この呼び出し方法について有識者にご判断いただきたい)git revert
してあるChecklist