Fix --file fish completion
#3036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume the fish completions were created by copy/pasting `--help` output, and `--file` was mistakenly left in instead of being translated to `-l file` (that is, `--file` was passed to `complete` instead of indicating that there is an option _named_ `--file`.) This leads to an error when using the completions: complete: --file: unknown option /run/current-system/sw/share/fish/vendor_completions.d/hub.fish (line 52): complete -f -c hub -n ' __fish_hub_using_command pull-request' -s F --file -d "Read the pull request title and description from <FILE>" ^ from sourcing file /run/current-system/sw/share/fish/vendor_completions.d/hub.fish (Type 'help complete' for related documentation) This patch fixes this error.
|
Fixes #2992 |
|
thanks! I wonder if this will be released anytime soon - considering that the latest release was in 2020 |
|
Yes, this will likely not be merged/released (see #2470), but having the PR here means packagers can cherry-pick the patch for distribution, as I've done here for nixpkgs: NixOS/nixpkgs#217636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume the fish completions were created by copy/pasting
--helpoutput, and--filewas mistakenly left in instead of being translated to-l file(that is,--filewas passed tocompleteinstead of indicating that there is an option named--file.) This leads to an error when using the completions:This patch fixes this error.