Fixing an issue with a spoiling of the object singleton classes #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.stub method defined in minitest/mock executing an alias_method against singleton_class under the hood.
Running an alias_method over a singleton_class without running a 'remove_method' later will keep singleton_class 'dirty' and running undef_method might clear more than needed.
Usually this will not lead to any consequences, but if you are stubbing methods of a global objects and trying to enrich functionality of their ancestors chain 'after' the the first stubbing is done, then you might fall into trouble.
Even though the probability for such a case is tiny, it's not 0 and singleton class should be kept clean.