Add ILM metrics in metrics-v3 #19539
Open
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
8772cb3
to
5569cda
Compare
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
5569cda
to
511eb44
Compare
anjalshireesh
requested changes
May 6, 2024
anjalshireesh
requested review from
vadmeste,
krisis,
harshavardhana and
kannappanr
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
511eb44
to
d8ef595
Compare
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
2 times, most recently
from
1624665
to
b5affab
Compare
anjalshireesh
requested changes
May 23, 2024
There was a problem hiding this comment.
As per latest discussions, the ilm metrics should be per-server (not cluster level), and should be moved from /cluster/ilm to root level i.e. /ilm cc @kannappanr
balamurugana
changed the title
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
2 times, most recently
from
9aeb390
to
2f31cfc
Compare
anjalshireesh
requested changes
May 24, 2024
| @@ -343,3 +343,13 @@ The standard metrics group for GoCollector is not shown below. | |||
| | `minio_replication_max_queued_bytes` | `gauge` | Maximum number of bytes queued for replication since server start | `server` | | |||
| | `minio_replication_max_queued_count` | `gauge` | Maximum number of objects queued for replication since server start | `server` | | |||
| | `minio_replication_max_data_transfer_rate` | `gauge` | Maximum replication data transfer rate in bytes/sec seen since server start | `server` | | |||
|
|
|||
| ### `/ilm` | |||
There was a problem hiding this comment.
Can we add a section at the top of the document also like we have for other root level metrics like audit, notification, etc ?
There was a problem hiding this comment.
It is next to /replication and /notification
docs/metrics/v3.md
Outdated
Comment on lines
349
to
355
| | Name | Type | Help | Labels | | ||
| |-------------------------------------------------------|-----------|----------------------------------------------------------------------------|--------| | ||
| | `minio_cluster_ilm_expiry_pending_tasks` | `counter` | Number of pending ILM expiry tasks in the queue | | | ||
| | `minio_cluster_ilm_transition_active_tasks` | `counter` | Number of active ILM transition tasks | | | ||
| | `minio_cluster_ilm_transition_missed_immediate_tasks` | `counter` | Number of missed immediate ILM transition tasks | | | ||
| | `minio_cluster_ilm_transition_pending_tasks` | `counter` | Number of pending ILM transition tasks in the queue | | | ||
| | `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions checked for ilm actions since server start | | |
There was a problem hiding this comment.
Need to add the server label to these metrics now
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
2f31cfc
to
31542d2
Compare
Co-authored-by: Shireesh Anjal <[email protected]> Signed-off-by: Bala.FA <[email protected]>
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
31542d2
to
c6e09df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Endpoint: /minio/metrics/v3/ilm
Metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)