Skip to content

Commit

Permalink
Move /system/go to /debug/go (#19707)
Browse files Browse the repository at this point in the history
  • Loading branch information
anjalshireesh committed May 14, 2024
1 parent 4e5fcca commit b2a8224
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
5 changes: 3 additions & 2 deletions cmd/metrics-v3.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ const (
systemMemoryCollectorPath collectorPath = "/system/memory"
systemCPUCollectorPath collectorPath = "/system/cpu"
systemProcessCollectorPath collectorPath = "/system/process"
systemGoCollectorPath collectorPath = "/system/go"

debugGoCollectorPath collectorPath = "/debug/go"

clusterHealthCollectorPath collectorPath = "/cluster/health"
clusterUsageObjectsCollectorPath collectorPath = "/cluster/usage/objects"
Expand Down Expand Up @@ -350,7 +351,7 @@ func newMetricGroups(r *prometheus.Registry) *metricsV3Collection {

// Create all Non-`MetricGroup` collectors here.
collectors := map[collectorPath]prometheus.Collector{
systemGoCollectorPath: collectors.NewGoCollector(),
debugGoCollectorPath: collectors.NewGoCollector(),
}

// Add all `MetricGroup` collectors to the map.
Expand Down
10 changes: 9 additions & 1 deletion docs/metrics/v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,15 @@ These are metrics about the minio process and the node.
| `/system/memory` | Metrics about memory on the system |
| `/system/network/internode` | Metrics about internode requests made by the node |
| `/system/process` | Standard process metrics |
| `/system/go` | Standard Go lang metrics |
| | |

### Debug metrics

These are metrics for debugging

| Path | Description |
|-----------------------------|---------------------------------------------------|
| `/debug/go` | Standard Go lang metrics |
| | |

### Cluster metrics
Expand Down

0 comments on commit b2a8224

Please sign in to comment.