Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description field to feed settings #2616

Merged
merged 1 commit into from May 6, 2024
Merged

Conversation

jlelse
Copy link
Contributor

@jlelse jlelse commented Apr 21, 2024

This adds a new "notes" field to the feed settings. This allows to save custom notes regarding a feed. It is also exported and imported as "description" in OPML.

Screenshot of the new feature

Do you follow the guidelines?

@fguillot
Copy link
Member

This adds a new "notes" field to the feed settings. This allows to save custom notes regarding a feed

Interesting. I never thought about that. I'm wondering what kind of notes people might want to associate with a feed.

It is also exported and imported as "description" in OPML.

This one could be problematic in the future. Today, Miniflux does not parse the description field from RSS feeds, but it's something that could be easily implemented. There is a related feature request: #2605.

@jlelse
Copy link
Contributor Author

jlelse commented Apr 23, 2024

I'm wondering what kind of notes people might want to associate with a feed.

I currently use the Miniflux API to get the OPML and automatically update the blogroll on my blog. But that's just a list of random links. I want to add some context to say why I am following those blogs.

@jlelse
Copy link
Contributor Author

jlelse commented Apr 23, 2024

This one could be problematic in the future.

What is problematic about that?

@rebron1900
Copy link

Glad someone shares the same idea as me.
I also display my RSS subscription list on my blog and want to note the reasons for subscribing to each RSS feed.

@fguillot
Copy link
Member

This one could be problematic in the future.

What is problematic about that?

If Miniflux starts to parse and store the description field from RSS feeds in the near future, then it would make sense to add it to the OPML export as well. We can't have both the feed description and the notes field using the same OPML description attribute.

@jlelse
Copy link
Contributor Author

jlelse commented Apr 24, 2024

I think the notes field can be filled with the feed description by default. But the same way the feed title can be modified, the feed description can be as well. No problem to rename "Notes" to "Feed description". 😊

@fguillot
Copy link
Member

fguillot commented May 2, 2024

I think the notes field can be filled with the feed description by default. But the same way the feed title can be modified, the feed description can be as well. No problem to rename "Notes" to "Feed description". 😊

Let's rename the notes field to description then.

@jlelse jlelse changed the title Add notes field to feed settings Add description field to feed settings May 2, 2024
@jlelse
Copy link
Contributor Author

jlelse commented May 2, 2024

Renamed everything in the code. 🙂

@fguillot
Copy link
Member

fguillot commented May 5, 2024

I merged another pull request that conflicts with yours. It would be nice if you could rebase this PR.

This adds a new "description" field to the feed settings. This allows to
save custom description regarding a feed. It is also exported and
imported as "description" in OPML.
@jlelse
Copy link
Contributor Author

jlelse commented May 6, 2024

I rebased the branch.

@fguillot fguillot merged commit a33b1ad into miniflux:main May 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants