Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show author of a post in the feed list #1424

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Show author of a post in the feed list #1424

Changes from 5 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
317a4d6
Show author of a post in the feed list
mcnesium Apr 27, 2022
91c8598
add title attribute with the author name not truncated
mcnesium May 17, 2022
052d87a
Merge branch 'miniflux:master' into patch-1
mcnesium May 28, 2022
e2ee460
Merge remote-tracking branch 'upstream/master' into patch-1
mcnesium Jul 20, 2022
c16f445
Merge branch 'main' into patch-1
mcnesium Nov 15, 2022
c32ec02
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Apr 10, 2023
7dbfc55
replace em element with less semantic span
mcnesium Jun 5, 2023
5912df5
Merge branch 'patch-1' of github.com:mcnesium/miniflux into patch-1
mcnesium Jul 6, 2023
2aab9ad
Merge branch 'main' into patch-1
mcnesium Jul 6, 2023
a272e91
Merge remote-tracking branch 'upstream/main' into patch-1
mcnesium Aug 21, 2023
d9925d7
Merge branch 'patch-1' of github.com:mcnesium/miniflux into patch-1
mcnesium Aug 21, 2023
2e228ba
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Aug 21, 2023
1589c9c
Merge remote-tracking branch 'upstream/main' into patch-1
mcnesium Oct 16, 2023
4b4cd22
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Oct 18, 2023
893dea2
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Jan 7, 2024
9931499
Merge branch 'main' into patch-1
mcnesium Feb 5, 2024
51e54b2
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Feb 20, 2024
d907380
Merge branch 'main' of github.com:miniflux/v2 into patch-1
mcnesium Mar 12, 2024
2c8d51b
Merge branch 'main' into patch-1
mcnesium Mar 12, 2024
47903f6
Merge branch 'patch-1' of github.com:mcnesium/miniflux into patch-1
mcnesium Mar 12, 2024
abdc35b
Merge branch 'miniflux:main' into patch-1
mcnesium Apr 19, 2024
1c03439
Merge branch 'miniflux:main' into patch-1
mcnesium May 2, 2024
6be3f29
Merge branch 'miniflux:main' into patch-1
mcnesium May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions template/templates/common/item_meta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
<li class="item-meta-info-title">
<a href="{{ route "feedEntries" "feedID" .entry.Feed.ID }}" title="{{ .entry.Feed.SiteURL }}" data-feed-link="true">{{ truncate .entry.Feed.Title 35 }}</a>
</li>
{{ if .entry.Author }}
<li class="item-meta-info-author">
<em title="{{ .entry.Author }}">{{ truncate .entry.Author 35 }}</em>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the semantic meaning for using <em>? If the answer is: to visually style the element in italics, then this should prefer CSS over using the <em> element.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I had no specific reason to choose <em> over something less semantic 😬

If you think it is inappropriate I am happy to (have you) change it to e.g. <span> or remove the extra inline element completely, if that would not break stuff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

.item-meta-info-author {
	font-style: italic;
}

is all that would be needed.

</li>
{{ end }}
<li class="item-meta-info-timestamp">
<time datetime="{{ isodate .entry.Date }}" title="{{ isodate .entry.Date }}">{{ elapsed .user.Timezone .entry.Date }}</time>
</li>
Expand Down