Add setting to control "Saving" list behavior #1263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved from the visible list immediately or after the Ajax request finishes
… so tests are happy
2 tasks
|
Closing stale PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1168 implemented a "Saving" message when an entry is marked as read in a list, delaying the entry's visual removal until the Ajax request completes. This is useful, but it also causes visual stuttering, which can be a pain point when trying to quickly work through a large number of entries (and using the keyboard shortcuts).
I couldn't think of a way to keep the "Saving" usefulness and retain snappy behavior, so I created a setting to let the user choose which behavior they'd prefer.
I haven't added localization yet, because I wasn't sure about the specific terminology I used. If it's acceptable, I'll add localization.