Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

star&fork count use githubbadges #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

star&fork count use githubbadges #12

wants to merge 6 commits into from

Conversation

llitfkitfk
Copy link

No description provided.

@mingrammer
Copy link
Owner

it is too small to see at all ..

@mingrammer
Copy link
Owner

Hm, A little bit hard to read at least for me. Are there reasons to use the badges?

@llitfkitfk
Copy link
Author

for auto-update

@mingrammer
Copy link
Owner

As we have an auto update script and I think that it is not very important that the stars & forks should be updated in realtime.

And it is a little bit hard to read because it's small size.

@llitfkitfk
Copy link
Author

yes, I try to fix the small size svg issue.
But markdown table format not allowed

@llitfkitfk
Copy link
Author

@mingrammer fixed size issue

@mingrammer
Copy link
Owner

Yes, I see.

As I don't know, It is possible to use badges for open Issues?

The open issue column was added by mattn : #10

@llitfkitfk
Copy link
Author

add open issue

@mingrammer
Copy link
Owner

I checked it.

But in this time, I think that there could be a problem. The beego and gin has difference of about 600 stars. (about 12200 and 11600) But the badges tell as if both have same number of stars. (12k)

How do you think about this?

@llitfkitfk
Copy link
Author

wait for badges/shields#999 ?

@stzminjae
Copy link
Contributor

Yes, we should use that raw count instead of short for this repository

@llitfkitfk
Copy link
Author

llitfkitfk commented Sep 12, 2017

How about using githubbadges for stars/forks and shields for issue?

If shields support raw star and forks full count in the future, re-update then.

Any thought?

@mingrammer
Copy link
Owner

I want to keep consistency so that they have same format.

Using the shields only for issue count, the README could be not clean I think.

@mingrammer
Copy link
Owner

But, does Githubbadges means githubbadges.com ?

@llitfkitfk
Copy link
Author

Yes

@stzminjae
Copy link
Contributor

That's ok. I see that it shows full count.

The last issue could be there. It's README has about 30 web frameworks. So, it should requests the badges almost 90 times. It is too many and could causes slow rendering the count.

So .. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants