BREAKING: remove v3 and deprecations #168
Open
+231
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR because the github v3 branch protections API breaks idempotency by showing a change on
contexts/checksonce applied, therefore tests were failing on my other PR.Removes branch_protections_v3 and only uses v4
removes deprecated downloads feature
Removes a lot of try,catch in favor of using terraform variable defaults
BREAKING: restructures branch_protections into map instead of list(map)
BREAKING: removes downloads
BREAKING: upgrades providers, some properties for repository have been renamed on github's API