Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove v3 and deprecations #168

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kevcube
Copy link
Collaborator

@kevcube kevcube commented May 16, 2024

I made this PR because the github v3 branch protections API breaks idempotency by showing a change on contexts/checks once applied, therefore tests were failing on my other PR.

Removes branch_protections_v3 and only uses v4

removes deprecated downloads feature

Removes a lot of try,catch in favor of using terraform variable defaults

BREAKING: restructures branch_protections into map instead of list(map)
BREAKING: removes downloads
BREAKING: upgrades providers, some properties for repository have been renamed on github's API

@kevcube kevcube requested review from mariux and a team as code owners May 16, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant