Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a return value type comment to the list collections function #1666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a return value type comment to the list collections function #1666

wants to merge 1 commit into from

Conversation

ponponon
Copy link
Contributor

@ponponon ponponon commented Sep 1, 2023

Adding more type comments to functions makes writing code more enjoyable and burdenless

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ponponon
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Sep 1, 2023
@XuanYang-cn
Copy link
Contributor

@ponponon Sorry for the late response. Please rebase the latest code so that the code checker will pass, THX

@XuanYang-cn XuanYang-cn added this to the 2.3.2 milestone Sep 22, 2023
@XuanYang-cn
Copy link
Contributor

Adding this PR to 2.3.2 milestone

@XuanYang-cn
Copy link
Contributor

@ponponon we're about to release pymilvus 2.3.2, are you still interested merging this PR into pymilvus 2.3.2? If so, please rebase the latest master code to fix the code checker problem.

Thanks again for your contribution. ❤️

@XuanYang-cn XuanYang-cn removed this from the 2.3.2 milestone Oct 24, 2023
@mergify mergify bot added needs-dco and removed dco-passed labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees
No one assigned
Labels
needs-dco size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ponponon @sre-ci-robot @XuanYang-cn