Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine logs of cgo pool #33373

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.16%. Comparing base (303470f) to head (0e73329).
Report is 42 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33373      +/-   ##
==========================================
- Coverage   82.19%   82.16%   -0.03%     
==========================================
  Files        1009     1012       +3     
  Lines      128849   128854       +5     
==========================================
- Hits       105901   105868      -33     
- Misses      18951    19016      +65     
+ Partials     3997     3970      -27     
Files Coverage Δ
internal/querynodev2/segments/pool.go 97.36% <100.00%> (+0.10%) ⬆️
internal/querynodev2/segments/segment.go 67.14% <0.00%> (ø)

... and 95 files with indirect coverage changes

@czs007 czs007 merged commit 0d3272e into milvus-io:master May 27, 2024
13 of 15 checks passed
@jaime0815 jaime0815 deleted the rf-log-524 branch May 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants