Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Panic if ProcessActiveStandBy returns error #33369

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: Panic if ProcessActiveStandBy returns error #33369

merged 1 commit into from
Jun 19, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented May 24, 2024 •
edited

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 24, 2024
longjiquan
longjiquan reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This was referenced May 24, 2024
Merged
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented May 24, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (e895cfe) to head (409aad3).
Report is 173 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33369      +/-   ##
==========================================
- Coverage   82.11%   82.11%   -0.01%     
==========================================
  Files        1012     1012              
  Lines      128829   128851      +22     
==========================================
+ Hits       105793   105801       +8     
- Misses      19062    19070       +8     
- Partials     3974     3980       +6
Files Coverage Δ
internal/querycoordv2/server.go 83.40% <0.00%> (ø)
internal/rootcoord/root_coord.go 91.96% <0.00%> (ø)
internal/datacoord/server.go 70.77% <0.00%> (-0.46%) ⬇️

... and 33 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

xiaofan-luan pushed a commit that referenced this pull request May 27, 2024
@wayblink
fix:[cherry-pick]Panic if ProcessActiveStandBy returns error (#33371)
d409298 
pr:#33369
issue:#33368

Signed-off-by: wayblink <[email protected]>
xiaofan-luan pushed a commit that referenced this pull request May 27, 2024
@wayblink
fix:[cherry-pick]Panic if ProcessActiveStandBy returns error (#33372)
deebae7 
pr:#33369
issue:#33368

Signed-off-by: wayblink <[email protected]>
@xiaofan-luan
Copy link
Contributor

@wayblink
could you help on investigating this ci issue?
I've seen several times the compact test can not pass

@wayblink
Copy link
Contributor Author

@wayblink could you help on investigating this ci issue? I've seen several times the compact test can not pass

OK

@wayblink
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Jun 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 19, 2024
@sre-ci-robot sre-ci-robot merged commit 5fac2fa into milvus-io:master Jun 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan left review comments

@cydrain cydrain Awaiting requested review from cydrain

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@longjiquan longjiquan

@czs007 czs007

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wayblink @xiaofan-luan @czs007 @sre-ci-robot @longjiquan