Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize bitmap index #33358

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented May 24, 2024

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

@longjiquan
Copy link
Contributor

/lgtm

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 24, 2024

rerun ut

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 27, 2024

rerun ut

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 81.95991% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 82.19%. Comparing base (e71b7c7) to head (c144017).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33358      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.04%     
==========================================
  Files        1012     1005       -7     
  Lines      129185   129863     +678     
==========================================
+ Hits       106219   106736     +517     
- Misses      18996    19158     +162     
+ Partials     3970     3969       -1     
Files Coverage Δ
internal/core/src/index/Index.h 100.00% <ø> (ø)
internal/core/src/index/StringIndexMarisa.h 100.00% <100.00%> (ø)
internal/core/src/index/Utils.cpp 37.25% <100.00%> (-5.01%) ⬇️
internal/core/src/index/Utils.h 100.00% <ø> (ø)
pkg/common/common.go 79.59% <ø> (+6.25%) ⬆️
pkg/util/indexparamcheck/bitmap_index_checker.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.50% <100.00%> (+<0.01%) ⬆️
internal/core/src/index/StringIndexMarisa.cpp 82.44% <50.00%> (+6.97%) ⬆️
internal/core/src/index/BitmapIndex.h 73.33% <75.00%> (-4.45%) ⬇️
internal/core/src/index/HybridScalarIndex.h 91.30% <91.30%> (ø)
... and 8 more

... and 226 files with indirect coverage changes

@zhagnlu zhagnlu force-pushed the optimize_bitmap branch 2 times, most recently from cf79741 to ca97431 Compare May 29, 2024 12:14
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label May 29, 2024
Copy link
Contributor

mergify bot commented May 29, 2024

@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the dco-passed DCO check passed. label May 29, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 29, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 30, 2024

rerun ut

@mergify mergify bot added the ci-passed label May 30, 2024
@czs007
Copy link
Contributor

czs007 commented May 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 589d4df into milvus-io:master May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants