Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use seperate warmup pool and disable warmup by default #33348

Merged
merged 7 commits into from
May 26, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented May 24, 2024

  1. use a small warmup pool to reduce the impact of warmup
  2. change the warmup pool to nonblocking mode
  3. disable warmup by default
  4. remove the maximum size limit of 16 for the load pool

issue: #32772

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@bigsheeper Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented May 24, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.13%. Comparing base (370562b) to head (6d0dbda).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33348   +/-   ##
=======================================
  Coverage   82.12%   82.13%           
=======================================
  Files        1012     1012           
  Lines      128851   128872   +21     
=======================================
+ Hits       105819   105847   +28     
+ Misses      19054    19036   -18     
- Partials     3978     3989   +11     
Files Coverage Δ
internal/querynodev2/segments/pool.go 100.00% <100.00%> (+2.73%) ⬆️
pkg/util/paramtable/component_param.go 98.49% <100.00%> (ø)
internal/querynodev2/segments/segment.go 67.14% <0.00%> (ø)

... and 37 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 24, 2024
@czs007
Copy link
Contributor

czs007 commented May 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 760223f into milvus-io:master May 26, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 28, 2024
…33349)

1. use a small warmup pool to reduce the impact of warmup
2. change the warmup pool to nonblocking mode
3. disable warmup by default
4. remove the maximum size limit of 16 for the load pool

issue: #32772

pr: #33348

---------

Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: xiaofanluan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants