Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sync dropped segment for dropped partition #33331

Merged
merged 8 commits into from
Jun 6, 2024
Merged

fix: Sync dropped segment for dropped partition #33331

merged 8 commits into from
Jun 6, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #33330

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 23, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request May 23, 2024
@XuanYang-cn
fix: [2.4]Sync dropped segment for dropped partition
cb808c0 
See also: milvus-io#33330
pr: milvus-io#33331

Signed-off-by: yangxuan <[email protected]>
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 23, 2024
@XuanYang-cn XuanYang-cn mentioned this pull request May 23, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 24, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (180d754) to head (bde4a36).
Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33331      +/-   ##
==========================================
+ Coverage   81.92%   82.01%   +0.09%     
==========================================
  Files        1014     1006       -8     
  Lines      130122   130358     +236     
==========================================
+ Hits       106599   106917     +318     
+ Misses      19528    19466      -62     
+ Partials     3995     3975      -20
Files Coverage Δ
internal/datanode/flow_graph_write_node.go 84.61% <100.00%> (+0.48%) ⬆️
internal/datanode/metacache/actions.go 91.76% <100.00%> (+0.51%) ⬆️
internal/datanode/writebuffer/manager.go 95.03% <100.00%> (+0.29%) ⬆️
internal/datanode/writebuffer/options.go 78.57% <100.00%> (+0.79%) ⬆️
internal/datanode/writebuffer/sync_policy.go 97.18% <100.00%> (+0.26%) ⬆️
internal/datanode/writebuffer/write_buffer.go 89.88% <100.00%> (-1.71%) ⬇️
internal/datanode/syncmgr/task.go 98.39% <50.00%> (-1.61%) ⬇️

... and 221 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 24, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels May 27, 2024
sre-ci-robot pushed a commit that referenced this pull request May 27, 2024
@XuanYang-cn
fix: [2.4]Sync dropped segment for dropped partition (#33332)
07b995f 
See also: #33330
pr: #33331

---------

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this pull request May 28, 2024
Merged
@XuanYang-cn
Copy link
Contributor Author

/hold for #33400

@XuanYang-cn
Copy link
Contributor Author

/unhold

@mergify mergify bot removed the ci-passed label Jun 3, 2024
@mergify mergify bot added the ci-passed label Jun 3, 2024
congqixia
congqixia approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 68c9e7d into milvus-io:master Jun 6, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the fix/drop-partition branch June 14, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XuanYang-cn @sre-ci-robot @congqixia