Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Decouple compaction from shard #33138

Merged
merged 33 commits into from
May 24, 2024

Conversation

bigsheeper
Copy link
Contributor

Decouple compaction from shard, remove dependencies on shards (e.g. SyncSegments, injection).

issue: #32809

Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test labels May 17, 2024
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 90.59829% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 82.13%. Comparing base (32d3e22) to head (fb60f42).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33138      +/-   ##
==========================================
+ Coverage   82.07%   82.13%   +0.06%     
==========================================
  Files        1003     1003              
  Lines      128993   128929      -64     
==========================================
+ Hits       105869   105901      +32     
+ Misses      19138    19058      -80     
+ Partials     3986     3970      -16     
Files Coverage Δ
internal/datacoord/compaction.go 89.85% <100.00%> (+2.14%) ⬆️
internal/datacoord/compaction_scheduler.go 96.99% <100.00%> (-3.01%) ⬇️
internal/datacoord/server.go 70.92% <100.00%> (-0.46%) ⬇️
internal/datanode/compaction/mix_compactor.go 82.58% <100.00%> (+2.95%) ⬆️
internal/datanode/syncmgr/sync_manager.go 92.40% <ø> (-0.37%) ⬇️
internal/datanode/compaction_executor.go 93.26% <83.33%> (-0.13%) ⬇️
internal/datacoord/compaction_trigger.go 87.06% <60.00%> (+2.91%) ⬆️
internal/datanode/l0_compactor.go 90.15% <83.33%> (+11.02%) ⬆️
internal/datacoord/compaction_trigger_v2.go 90.24% <82.35%> (-1.54%) ⬇️
internal/datanode/services.go 88.62% <25.00%> (+3.37%) ⬆️

... and 32 files with indirect coverage changes

Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added ci-passed and removed ci-passed labels May 22, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels May 22, 2024
@mergify mergify bot removed the ci-passed label May 23, 2024
@mergify mergify bot added the ci-passed label May 23, 2024
@XuanYang-cn
Copy link
Contributor

/lgtm

@czs007
Copy link
Contributor

czs007 commented May 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7730b91 into milvus-io:master May 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants