Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Store SparseFloatVector into numpy as JSON string #33134

Closed
wants to merge 1 commit into from
Closed

enhance: Store SparseFloatVector into numpy as JSON string #33134

wants to merge 1 commit into from

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented May 17, 2024

Issue: #22837

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cydrain
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 17, 2024
@zhengbuqian
Copy link
Collaborator

we'll use the numpy format instead of json for sparse vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cydrain @sre-ci-robot @zhengbuqian