Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: decrease cpu overhead during filter segments on datacoord #33130

Merged
merged 1 commit into from
May 28, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #33129

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 17, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the decrease-cpu-overhead branch 2 times, most recently from 5bfb7d3 to 3a86a95 Compare May 17, 2024 09:11
Copy link
Contributor

mergify bot commented May 17, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/approve

Copy link
Contributor

mergify bot commented May 20, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (1b67cec) to head (ad33c28).
Report is 22 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33130      +/-   ##
==========================================
+ Coverage   82.06%   82.12%   +0.05%     
==========================================
  Files        1012     1012              
  Lines      128952   128974      +22     
==========================================
+ Hits       105829   105916      +87     
+ Misses      19120    19077      -43     
+ Partials     4003     3981      -22     
Files Coverage Δ
internal/datacoord/segment_info.go 89.21% <100.00%> (+1.91%) ⬆️
internal/querynodev2/segments/segment.go 66.59% <ø> (-0.55%) ⬇️
internal/datacoord/segment_operator.go 85.18% <66.66%> (-6.82%) ⬇️

... and 33 files with indirect coverage changes

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 21, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3d29907 into milvus-io:master May 28, 2024
15 checks passed
@jaime0815 jaime0815 deleted the decrease-cpu-overhead branch June 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants