Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid memoryleak in rendezvousFlushManager #33112

Merged
merged 1 commit into from
May 20, 2024

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented May 17, 2024

issue: #33110

@czs007 czs007 added kind/bug Issues or changes related a bug kind/branch-feature labels May 17, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels May 17, 2024
@mergify mergify bot added the dco-passed DCO check passed. label May 17, 2024
@czs007 czs007 added this to the 2.3.16 milestone May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.08%. Comparing base (7a617e2) to head (d88e479).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33112      +/-   ##
==========================================
- Coverage   83.10%   83.08%   -0.02%     
==========================================
  Files         850      850              
  Lines      106653   106706      +53     
==========================================
+ Hits        88631    88657      +26     
- Misses      14725    14742      +17     
- Partials     3297     3307      +10     
Files Coverage Δ
internal/datanode/data_sync_service.go 86.25% <100.00%> (+0.10%) ⬆️
pkg/util/paramtable/component_param.go 98.26% <100.00%> (+<0.01%) ⬆️
internal/datanode/flush_manager.go 92.59% <97.72%> (+0.43%) ⬆️

... and 16 files with indirect coverage changes

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 17, 2024
@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented May 17, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 19, 2024

/run-cpu-e2e

@czs007
Copy link
Contributor Author

czs007 commented May 20, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 20, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 20, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 20, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented May 20, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 20, 2024
@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 23e7155 into milvus-io:2.3 May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants